About UnitBuffInfo Change

Quote from Serenadae

Not sure where to ask this. So please move it somewhere else, if appropriate.

• Fixed UnitBuffInfo was able to access hidden buffs information unintentionally.

Could a DEV explain why this change was necessary ?

Yes pls explain. How should players read out buffs now, that prevent specific buffs. For example the 15sec CD of Warden 104 ISS was triggert of a hidden buff

Quote from xLutinex

Quote from Serenadae

Not sure where to ask this. So please move it somewhere else, if appropriate.

• Fixed UnitBuffInfo was able to access hidden buffs information unintentionally.

Could a DEV explain why this change was necessary ?

Yes pls explain. How should players read out buffs now, that prevent specific buffs. For example the 15sec CD of Warden 104 ISS was triggert of a hidden buff

And how we should do that? grox

Quote from Serenadae

So we need to use clunky timers again for skill procs ? That is very unfortunate and means a lot of work.

I honestly don't see why this was seen as a problem in the first place.

Moreover, there seems to be a general issue with UnitBuffInfo after the patch, that is not directly related to hidden buffs.

I had to switch to UnitBuff for my stack-counters (for skills such as Forge-Effect from Champion) since UnitBuffInfo ceased to work. Forge-Effect is not a hidden buff, it is displayed and has both name and ID.

Not quite sure what causes this, but I suspect the latest change to hidden buffs prevents my function from iterating through my (ordinary) buffs as it should. Using UnitBuff it works.

Display More

I agree and had the same problems. Seems like UnitBuffInfo now only works on buffs which have a BuffTime. Permanent Buffs, without a BuffTime won't be detected by UnitBuffInfo, only UnitBuff.

Edit: I mean the ID of a permanent buff. Names still work.

Quote from Serenadae

So we need to use clunky timers again for skill procs ? That is very unfortunate and means a lot of work.

I honestly don't see why this was seen as a problem in the first place.

Moreover, there seems to be a general issue with UnitBuffInfo after the patch, that is not directly related to hidden buffs.

I had to switch to UnitBuff for my stack-counters (for skills such as Forge-Effect from Champion) since UnitBuffInfo ceased to work. Forge-Effect is not a hidden buff, it is displayed and has both name and ID.

Not quite sure what causes this, but I suspect the latest change to hidden buffs prevents my function from iterating through my (ordinary) buffs as it should. Using UnitBuff it works.

Display More

Regarding timers, a friend of mine has found a solution to avoid timers.

Saving the current time when your skill was casted with "GetTime()" and then comparing the difference of that registered time against the current "GetTime()" with your condition is a very efficient way to avoid timers.

Not quite the solution you were looking for probably, but this works really well when there's no other way.

A simple (quick and dirty) example function that does something like this:

local C_TIMERS = {};

-- Use in your condition
function isTimedSkillReady(name, duration)
  -- No registered time, skill should be ready.
  if (not C_TIMERS[name]) then
    return true;
  end

  -- If the registered time + duration is less than or equal to the current time, skill should be ready.
  if ((C_TIMERS[name] + duration) <= GetTime()) then
    C_TIMERS[name] = nil;
    return true;
  end

  -- Skill is not ready.
  return false;
end

-- Use when casting the skill
function setTimer(name)
  if (C_TIMERS[name] then
    return;
  end

  C_TIMERS[name] = GetTime();
end